[FEM.Elastic] Introduce generic element-agnostic elastic FEM force field#5882
Open
alxbilger wants to merge 6 commits intosofa-framework:masterfrom
Open
[FEM.Elastic] Introduce generic element-agnostic elastic FEM force field#5882alxbilger wants to merge 6 commits intosofa-framework:masterfrom
alxbilger wants to merge 6 commits intosofa-framework:masterfrom
Conversation
alxbilger
added
pr: status to review
hugtalbot
added
the
topic for next dev-meeting
Contributor
|
[ci-build][with-all-tests] |
th-skam
reviewed
Feb 2, 2026
Contributor
th-skam
left a comment
th-skam
left a comment
There was a problem hiding this comment.
I only touched some easy to read files. Will try to take a better look in the next days.
But I really like the overall work.
| template<sofa::Size L, sofa::Size C, typename ValueType> | ||
| sofa::type::Vec<L, ValueType> operator*(const sofa::type::Mat<L, C, ValueType>& mat, const VecView<C, ValueType>& vec) | ||
| { | ||
| sofa::type::Vec<L, ValueType> res(sofa::type::NOINIT); |
Contributor
There was a problem hiding this comment.
Suggested change
| sofa::type::Vec<L, ValueType> res(sofa::type::NOINIT); | |
| sofa::type::Vec<L, ValueType> res; |
There's a res+= a few lines later and should be initialized.
Contributor
Author
There was a problem hiding this comment.
Thanks! This has to be changed in the other operator too
alxbilger
removed
the
topic for next dev-meeting
Contributor
|
This PR deserves the attention of all @sofa-framework/reviewers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coming from https://github.com/alxbilger/Elasticity
TODO:
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if